bpo-31676: Fix test_imp.test_load_source() side effect #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/test/test_imp.py
Outdated
| tmp_mod = type(sys.modules[__name__])(__name__) | ||
| with support.swap_item(sys.modules, __name__, tmp_mod): | ||
| with self.assertRaisesRegex(ValueError, 'embedded null'): | ||
| imp.load_source(__name__, __file__ + "\0") |
There was a problem hiding this comment.
Wouldn't be safe to not use the name of an existing module?
test_load_source() now replaces the current __name__ module with a temporary module to prevent side effects.
vstinner
changed the title
|
Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3988 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 13, 2017
Mariatta
pushed a commit
that referenced
this pull request
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_load_source() now replaces the current
__name__module with atemporary module to prevent side effects.
https://bugs.python.org/issue31676