Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-6986: Add a comment to clarify a test of _json.make_encoder() #3789

Merged
merged 3 commits into from
Mar 26, 2018
Merged

bpo-6986: Add a comment to clarify a test of _json.make_encoder() #3789

merged 3 commits into from
Mar 26, 2018

Conversation

orenmn
Copy link
Contributor

@orenmn orenmn commented Sep 27, 2017 •
edited by bedevere-bot
Loading

vstinner
vstinner requested changes Sep 27, 2017
View reviewed changes
Lib/test/test_json/test_speedups.py Outdated
@@ -31,6 +31,8 @@ def test(value):

class TestEncode(CTest):
def test_make_encoder(self):
# Issue #6986: The interpreter shouldn't crash in case c_make_encoder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new syntax "bpo-6986" rather than "Issue #6986", it prevents confusion between bugs.python.org bug tracker and GitHub bug tracker ;-)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Sep 27, 2017
View reviewed changes
Lib/test/test_json/test_speedups.py Outdated
@@ -31,6 +31,8 @@ def test(value):

class TestEncode(CTest):
def test_make_encoder(self):
# Issue #6986: The interpreter shouldn't crash in case c_make_encoder()
# receives invalid arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly invalid argument is tested?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just insufficient number of arguments? Then why not just call it without arguments? Or call it with 8 valid arguments (it requires 9 arguments)?

Copy link
Contributor Author

@orenmn orenmn Sep 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that before Victor's patch was committed, these specially crafted arguments would cause a crash, and with the patch, nothing bad would happen. (Victor, please correct me if I am wrong.)

Maybe changing the test's name would make it clearer? Or do you have something else in mind?

@orenmn
Copy link
Contributor Author

orenmn commented Sep 27, 2017

I didn't expect the Spanish Inquisition!

@bedevere-bot
Copy link

Nobody expects the Spanish Inquisition!

@Haypo: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Mar 26, 2018
@serhiy-storchaka serhiy-storchaka merged commit 7c2d978 into python:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@vstinner vstinner vstinner requested changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orenmn @bedevere-bot @vstinner @serhiy-storchaka @the-knights-who-say-ni