Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-77749: Fix inconsistent behavior of non-ascii handling in EmailPolicy.fold #6986

Merged
merged 7 commits into from
Jan 26, 2024
Merged

gh-77749: Fix inconsistent behavior of non-ascii handling in EmailPolicy.fold #6986

merged 7 commits into from
Jan 26, 2024

Conversation

Licht-T
Copy link
Contributor

@Licht-T Licht-T commented May 19, 2018 •
edited by bedevere-app bot
Loading

@Licht-T Licht-T requested a review from a team as a code owner May 19, 2018 15:07
@Licht-T Licht-T mannequin mentioned this pull request May 21, 2022
Closed
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 19, 2022
@serhiy-storchaka serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Jan 26, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved conflicts, added a NEWS entry and optimized the code.

It LGTM now.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jan 26, 2024
@serhiy-storchaka serhiy-storchaka changed the title bpo-33568: Fix inconsistent behavior of non-ascii handling in EmailPolicy.fold gh-6986: Fix inconsistent behavior of non-ascii handling in EmailPolicy.fold Jan 26, 2024
@serhiy-storchaka serhiy-storchaka changed the title gh-6986: Fix inconsistent behavior of non-ascii handling in EmailPolicy.fold gh-77749: Fix inconsistent behavior of non-ascii handling in EmailPolicy.fold Jan 26, 2024
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) January 26, 2024 14:58
@serhiy-storchaka serhiy-storchaka merged commit 504334c into python:main Jan 26, 2024
@miss-islington-app
Copy link

Thanks @Licht-T for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 26, 2024
@Licht-T @serhiy-storchaka @miss-islington
pythongh-77749: Fix inconsistent behavior of non-ASCII handling in Em…
3251839 
…ailPolicy.fold() (pythonGH-6986)

It now always encodes non-ASCII characters in headers if utf8 is false.

(cherry picked from commit 504334c)

Co-authored-by: Rito Takeuchi <licht-t@outlook.jp>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 26, 2024
@Licht-T @serhiy-storchaka @miss-islington
pythongh-77749: Fix inconsistent behavior of non-ASCII handling in Em…
46e7618 
…ailPolicy.fold() (pythonGH-6986)

It now always encodes non-ASCII characters in headers if utf8 is false.

(cherry picked from commit 504334c)

Co-authored-by: Rito Takeuchi <licht-t@outlook.jp>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 26, 2024

GH-114606 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 26, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 26, 2024

GH-114607 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 26, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 26, 2024
@miss-islington @Licht-T @serhiy-storchaka
[3.12] gh-77749: Fix inconsistent behavior of non-ASCII handling in E…
fd8aafd 
…mailPolicy.fold() (GH-6986) (GH-114606)

It now always encodes non-ASCII characters in headers if utf8 is false.

(cherry picked from commit 504334c)

Co-authored-by: Rito Takeuchi <licht-t@outlook.jp>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 26, 2024
@miss-islington @Licht-T @serhiy-storchaka
[3.11] gh-77749: Fix inconsistent behavior of non-ASCII handling in E…
c09eae3 
…mailPolicy.fold() (GH-6986) (GH-114607)

It now always encodes non-ASCII characters in headers if utf8 is false.

(cherry picked from commit 504334c)

Co-authored-by: Rito Takeuchi <licht-t@outlook.jp>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Copy link
Member

Thank you for your contribution, @Licht-T, and sorry for the delay.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Licht-T @serhiy-storchaka @aisk
pythongh-77749: Fix inconsistent behavior of non-ASCII handling in Em…
0a757b1 
…ailPolicy.fold() (pythonGH-6986)

It now always encodes non-ASCII characters in headers if utf8 is false.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Licht-T @serhiy-storchaka @Glyphack
pythongh-77749: Fix inconsistent behavior of non-ASCII handling in Em…
0db8dab 
…ailPolicy.fold() (pythonGH-6986)

It now always encodes non-ASCII characters in headers if utf8 is false.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Licht-T @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot