gh-63075: IDLE editor - Auto insertion of the closers #3520

wohlganger · 2017-09-12T19:24:02Z

This patch is for Auto insertion of the closing parens, brackets, and braces enhancement. It includes necessary changes to config-extensions.def, and idlelib.test.test_config. It has its own test which covers all non - init statements. As of writing this, idlelib.tests passes on all tests other than calltips, which appears to be a preexisting problem.

https://bugs.python.org/issue18875

Issue: Idle: Auto insertion of the closing parens, brackets, and braces #63075

adds fg color, bg color, font, and underline options for parens highlighting

How did the change to the __doc__ of append not get fixed in the tests earlier?

Used incorrect / old python for testing.

…main.def

per terryjreedy request.

…highlight.

Fixing code conflict ate highlighting options. Needed to be re-introduced.

…eight as non-core keybinding test example.

…was before.

idleConf expects a string bool, not type bool. whoops.

In use, it was irritating for me to have both perform the action. This way, users can pick one or both or none.

terryjreedy

Now that we are no longer implementing new features as extensions, this patch needs to be rewritten before it can be properly review in action. If someone else wants to do so before I get to it, please say so in a comment.

The comments below indicate the major changes needed.

terryjreedy · 2018-04-06T02:23:10Z

Lib/idlelib/ParenClose.py

@@ -0,0 +1,115 @@
+"""


Add ParenClose to parenmatch.py.

terryjreedy · 2018-04-06T02:24:28Z

Lib/idlelib/ParenClose.py

+When you hit left paren or tick,
+automatically creates the closing paren or tick.
+
+Author: Charles M. Wohlganger


Remove. This already has input from 3 other people. I will list Charles as original author in the news entry.

terryjreedy · 2018-04-06T02:30:56Z

Lib/idlelib/ParenClose.py

+Add to the end of config-extensions.def :
+
+    [ParenClose]
+    enable = True


terryjreedy · 2018-04-06T02:32:26Z

Lib/idlelib/ParenClose.py

+    paren_close = True
+    tick_close = True
+    skip_closures = True
+    mutual_delete = True


I think defaults should be 'off', as in no change from current behavior. I am not sure what latter 2 mean. See below.

Changing the specification of the new feature by adding action on deletion should have been discussed on the issue. (This applies generally to changing specs.) Notepad++ does do anything special on deletion. Binding the deletion keys here prevents binding them elsewhere, and I have an idea of where it might be needed, as opposed to optional. I also think sometimes delete more and sometimes not is confusing. The deletion part of 2f19ca8 and anything later should be reverted unless and until there is a clear agreement on adding this.

terryjreedy · 2018-04-06T02:33:07Z

Lib/idlelib/ParenClose.py

+    tick_close = True
+    skip_closures = True
+    mutual_delete = True
+    [ParenClose_cfgBindings]


Delete section. Not needed for hard-coded features.

terryjreedy · 2018-04-06T03:19:47Z

Lib/idlelib/ParenClose.py

+    deleted before the new one is typed, effectively skipping over the closure.
+    If the cursor is between two closures and mutual_delete or mutual_backspace
+    is True, when the respective command is given, both closures are deleted.
+    '''


I don't really understand these.

terryjreedy · 2018-04-06T03:19:56Z

Lib/idlelib/config-extensions.def

@@ -63,3 +63,17 @@ z-text= Z
 z-in= <Control-Shift-KeyRelease-Insert>
 [ZzDummy_bindings]
 z-out= <Control-Shift-KeyRelease-Delete>
+


As I said above, put in config-general.

terryjreedy · 2018-04-06T03:20:05Z

Lib/idlelib/idle_test/test_config.py

+        eq(iGE(), ['ZzDummy', 'ParenClose'])
+        eq(iGE(editor_only=True), ['ZzDummy', 'ParenClose'])
+        eq(iGE(active_only=False), ['ZzDummy', 'ParenClose', 'DISABLE'])
+        eq(iGE(active_only=False, editor_only=True), ['ZzDummy', 'ParenClose', 'DISABLE'])


I believe that all these changes to test_config only apply to extensions, and are therefore not needed.

terryjreedy · 2018-04-06T03:20:30Z

Lib/idlelib/idle_test/test_parenclose.py

@@ -0,0 +1,97 @@
+'''Test idlelib.parenclose.


Add MockEvent and ParenCloseTest to test_parenmatch. I have not reviewed in detail, but have a couple of comments.

terryjreedy · 2018-04-06T03:20:37Z

Lib/idlelib/idle_test/test_parenclose.py

+        delete = p.delete_event
+        for paren_close_set, tick_close_set, skip_closures_set, mutual_b_set, \
+            mutual_d_set, insert, func, pos, char, result, posend in [
+              (1, 1, 1, 1, 1, 'def abuse', p_open, '1.9', '(',


for test_tuple in [<list of tuples>] would allow test_tuple to be passed to a helper function.

bedevere-bot · 2018-04-06T03:28:34Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Trigger a retest to see if CI produces same odd failures as on another PR.

csabella · 2018-04-06T11:33:39Z

I would like to help out, but I believe Charles would need to make the changes. I don't have 'push access' to his branch.

ghost · 2019-05-05T17:54:29Z

Hi,
this would be really helpful in IDLE; it's not just for lazy people, but to reduce errors caused by accidentally forgetting to close a (, ", [ or { .
It happens to me every day, and because of that, I'm considering switching to another editor.
Thanks for working on it!

Is it possible to somehow include this patch manually, after installation of Python, even if it's not fully worked-on here?

terryjreedy · 2020-07-21T02:15:24Z

This PR makes a unrelated changes to the unix file mode of Tools/ssl/multissltests.py. This must be reverted between this can be applied. I don't think I can do so in Windows. Clicking ... to the right gives an option to 'Delete file'. I have the impression that this actually adds file deletion to the PR rather than removing the file change from the PR.

terryjreedy · 2020-07-21T02:38:01Z

There is no patch to the IDLE doc. I now think that this perhaps even be the first thing to do, rather than a possibly delayed afterthought.

github-actions · 2022-02-21T00:08:40Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2022-08-30T00:15:22Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2022-09-30T00:22:36Z

This PR is stale because it has been open for 30 days with no activity.

wohlganger and others added 30 commits June 29, 2017 15:11

parenmatch highlighting options

5c57faf

adds fg color, bg color, font, and underline options for parens highlighting

fixed whitespace issue

d49170f

only select from highlighting options

8c3a966

fixed whitespace

757bb38

whitespace

d7e136c

Merge remote-tracking branch 'upstream/master'

b178af5

python#27099 - turn builtin extensions to reg modules

2adebb9

whitespace + fix I thought I already committed.

86c3d4c

warning fixes, removed old config entries

1c246fc

calltip append doc fix, default paren-fore fix, help update

0418ad0

How did the change to the __doc__ of append not get fixed in the tests earlier?

fix calltips

097a0d8

Used incorrect / old python for testing.

removed circular import

4232e77

fix warnings due to missing default config options in idlelib.config-…

a7b29f5

…main.def

Merge branch 'master' into master

e30b7b4

added format_pmaxw to config-main

252672b

Merge remote-tracking branch 'upstream/master'

999b573

replaced help.html edit with idle.rst edit

1a74591

per terryjreedy request.

Merge branch 'master' into master

3501c45

Merge remote-tracking branch 'upstream/master'

232f711

added conflict resolved var descriptions to docstring in create_page_…

f095c53

…highlight.

strip trailing whitespace

a661bfa

Merge branch 'master' into master

5c90a8f

re-introduced highlight options.

5a6a007

Fixing code conflict ate highlighting options. Needed to be re-introduced.

News blurb.

709b434

Reinstated zoomheight as an extension. Replaced autoexpand with zoomh…

b9b1f9a

…eight as non-core keybinding test example.

fixed configdialog test (wrong cases), fixed whitespace

8b76ccb

update idle.rst: zoomheight is an extension.

b986c12

more fixes for zoomheight - trying to minimize changes from master

f86acaa

zoomheight config fix, zoomheight should be fully back to the way it …

5805462

…was before.

whitespace

165b548

wohlganger added 9 commits September 13, 2017 11:33

added mutual delete / backspace. minor fixes

2f19ca8

PEP8 fixes.

6d2fa26

replace type option of bool with 'bool'

15f8d82

idleConf expects a string bool, not type bool. whoops.

Merge branch 'master' into 18875-Auto-insert-parens

d141abc

whitespace

caa9240

whitespace fixed with reindent.py

21f4482

trying to fix Tk for travis testing parenclose

25ba0f8

Set parenclose test as gui required

a4cd0e3

Added option to distinguish between mutual delete and mutual backspace

cffa9d6

In use, it was irritating for me to have both perform the action. This way, users can pick one or both or none.

terryjreedy requested changes Apr 6, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels Apr 6, 2018

Update ParenClose.py

9aaa395

Trigger a retest to see if CI produces same odd failures as on another PR.

github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 21, 2022

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 30, 2022

terryjreedy added the topic-IDLE label Aug 30, 2022

terryjreedy changed the title ~~bpo-18875 Auto insertion of the closing parens, brackets, braces, and ticks~~ gh-63075: IDLE editor - Auto insertion of the closers Aug 30, 2022

terryjreedy self-assigned this Aug 30, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 31, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-63075: IDLE editor - Auto insertion of the closers #3520

gh-63075: IDLE editor - Auto insertion of the closers #3520

wohlganger commented Sep 12, 2017 •

edited by bedevere-bot

Loading

terryjreedy left a comment

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Jul 21, 2020

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

terryjreedy Apr 6, 2018

bedevere-bot commented Apr 6, 2018

csabella commented Apr 6, 2018

ghost commented May 5, 2019

terryjreedy commented Jul 21, 2020

terryjreedy commented Jul 21, 2020

github-actions bot commented Feb 21, 2022

github-actions bot commented Aug 30, 2022

github-actions bot commented Sep 30, 2022

gh-63075: IDLE editor - Auto insertion of the closers #3520

Are you sure you want to change the base?

gh-63075: IDLE editor - Auto insertion of the closers #3520

Conversation

wohlganger commented Sep 12, 2017 • edited by bedevere-bot Loading

terryjreedy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bedevere-bot commented Apr 6, 2018

csabella commented Apr 6, 2018

ghost commented May 5, 2019

terryjreedy commented Jul 21, 2020

terryjreedy commented Jul 21, 2020

github-actions bot commented Feb 21, 2022

github-actions bot commented Aug 30, 2022

github-actions bot commented Sep 30, 2022

wohlganger commented Sep 12, 2017 •

edited by bedevere-bot

Loading