gh-63075: IDLE editor - Auto insertion of the closers

Lib/idlelib/ParenClose.py

@@ -0,0 +1,91 @@
+"""
+Parens and Ticks Closing Extension
+
+When you hit left paren or tick,
+automatically creates the closing paren or tick.
+
+Author: Charles M. Wohlganger
+        charles.wohlganger@gmail.com
+
+Last Updated: 12-Aug-2017 by Charles Wohlganger
+
+Add to the end of config-extensions.def :
+
+    [ParenClose]
+    enable = True
+    paren_close = True
+    tick_close = True
+    skip_closures = True
+    comment_space = True
+    [ParenClose_cfgBindings]
+    p-open = <Key-parenleft> <Key-bracketleft> <Key-braceleft>
+    t-open = <Key-'> <Key-">
+    p-close = <Key-parenright> <Key-bracketright> <Key-braceright>
+
+"""
+
+from idlelib.config import idleConf
+
+
+class ParenClose:
+    '''
+    When loaded as an extension to IDLE, and paren_close is True, the symbols
+    ([{ will have their closures printed after them and the insertion cursor
+    moved between the two.  The same is true for tick closures and the symbols
+    ' and ".  When \'\'\' or """ are typed and tick_close is True, it will also
+    produce the closing symbols. If skip_closures is True, then when a closure
+    symbol is typed and the same one is to the right of it, that symbols is
+    deleted before the new one is typed, effectively skipping over the closure.
+    '''
+    def __init__(self, editwin=None): #setting default to none makes testing easier
+        if editwin:
+            self.text = editwin.text
+        else:
+            self.text=None
+        self.paren_close = idleConf.GetOption(
+            'extensions', 'ParenClose', 'paren_close', default=True)
+        self.tick_close = idleConf.GetOption(
+            'extensions', 'ParenClose', 'tick_close', default=True)
+        self.skip_closures = idleConf.GetOption(
+            'extensions', 'ParenClose', 'skip_closures', default=True)
+        #sometimes idleConf loads boolean False as string "False"
+        if self.paren_close == 'False':
+            self.paren_close = False
+        if self.tick_close == 'False':
+            self.tick_close = False
+        if self.skip_closures == 'False':
+            self.skip_closures = False
+
+    def p_open_event(self, event):
+        if self.paren_close:
+            closer = {'(': ')', '[': ']', '{': '}'}[event.char]
+            pos = self.text.index('insert')
+            self.text.insert(pos, closer)
+            self.text.mark_set('insert', pos)
+
+    def p_close_event(self, event):
+        pos = self.text.index('insert')
+        if self.skip_closures \
+           and self.text.get(pos, pos + ' +1c') == event.char:
+            self.text.delete(pos, pos + '+1c')
+
+    def t_open_event(self, event):
+        if self.tick_close:
+            pos = self.text.index('insert')
+            if self.text.get(pos + ' -2c', pos) == event.char * 2 \
+               and self.text.get(pos, pos + ' +1c') != event.char:
+                # Instead of one tick, add two ticks if there are two;
+                # user wants to make docstring or multiline.
+                self.text.insert(pos, event.char * 3)
+                self.text.mark_set('insert', pos)
+            else:
+                if self.skip_closures \
+                   and self.text.get(pos, pos + ' +1c') == event.char:
+                    self.text.delete(pos, pos + ' +1c')
+                else:
+                    self.text.insert(pos, event.char)
+                    self.text.mark_set('insert', pos)
+
+if __name__ == '__main__':
+    import unittest
+    unittest.main('idlelib.idle_test.test_parenclose', verbosity=2)

Lib/idlelib/config-extensions.def

@@ -63,3 +63,13 @@ z-text= Z
 z-in= <Control-Shift-KeyRelease-Insert>
 [ZzDummy_bindings]
 z-out= <Control-Shift-KeyRelease-Delete>
+
+[ParenClose]
+enable = True
+paren_close = True
+tick_close = True
+skip_closures = True
+[ParenClose_cfgBindings]
+p-open = <Key-parenleft> <Key-bracketleft> <Key-braceleft>
+t-open = <Key-'> <Key-">
+p-close = <Key-parenright> <Key-bracketright> <Key-braceright>

Lib/idlelib/idle_test/test_config.py

@@ -436,30 +436,31 @@ def test_get_extensions(self):
         conf.SetOption('extensions', 'DISABLE', 'enable', 'False')
 
         eq = self.assertEqual
-        eq(conf.GetExtensions(),
-           ['ZzDummy'])
+        eq((conf.GetExtensions()),
+           ['ZzDummy', 'ParenClose'])
         eq(conf.GetExtensions(active_only=False),
-            ['ZzDummy', 'DISABLE'])
+            ['ZzDummy', 'ParenClose', 'DISABLE'])
         eq(conf.GetExtensions(editor_only=True),
-           ['ZzDummy'])
+           ['ZzDummy', 'ParenClose'])
         eq(conf.GetExtensions(shell_only=True),
-           [])
+           ['ParenClose'])
         eq(conf.GetExtensions(active_only=False, editor_only=True),
-           ['ZzDummy', 'DISABLE'])
+           ['ZzDummy', 'ParenClose', 'DISABLE'])
 
         # Add user extensions
         conf.SetOption('extensions', 'Foobar', 'enable', 'True')
         eq(conf.GetExtensions(),
-           ['ZzDummy', 'Foobar'])  # User extensions didn't sort
+           ['ZzDummy', 'ParenClose', 'Foobar'])  # User extensions didn't sort
         eq(conf.GetExtensions(active_only=False),
-           ['ZzDummy', 'DISABLE', 'Foobar'])
+           ['ZzDummy', 'ParenClose', 'DISABLE', 'Foobar'])
 
     def test_remove_key_bind_names(self):
         conf = self.mock_config()
 
         self.assertCountEqual(
             conf.RemoveKeyBindNames(conf.GetSectionList('default', 'extensions')),
-            ['AutoComplete', 'CodeContext', 'FormatParagraph', 'ParenMatch','ZzDummy'])
+            ['AutoComplete', 'CodeContext', 'FormatParagraph', 'ParenClose',
+             'ParenMatch','ZzDummy'])
 
     def test_get_extn_name_for_event(self):
         conf = self.mock_config()

Lib/idlelib/idle_test/test_parenclose.py

@@ -0,0 +1,78 @@
+'''Test idlelib.parenclose.
+'''
+from idlelib.ParenClose import ParenClose
+import unittest
+from unittest.mock import Mock
+from tkinter import Text  # mocktk doesn't do text position addition correctly
+
+
+class MockEvent(object):
+    def __init__(self, char):
+        self.char = char
+
+
+class ParenCloseTest(unittest.TestCase):
+    def test_parenClose(self):
+        self.p_open_event = ParenClose.p_open_event
+        self.p_close_event = ParenClose.p_close_event
+        self.t_open_event = ParenClose.t_open_event
+        self.text = Text()
+        p_open = self.p_open_event
+        p_close = self.p_close_event
+        t_open = self.t_open_event
+        for paren_close_set, tick_close_set, skip_closures_set, \
+            insert, func, pos, char, result, posend in [
+              (1, 1, 1, 'def abuse', p_open, '1.9', '(',
+               'def abuse()', '1.10'),
+              (1, 1, 1, 'spam = ', p_open, '1.7', '[',
+               'spam = []', '1.8'),
+              (1, 1, 1, 'eggs = ', p_open, '1.7', '{',
+               'eggs = {}', '1.8'),
+              (1, 1, 1, 'def abuse2()', p_close, '1.11', ')',
+               'def abuse2()', '1.12'),
+              (1, 1, 1, 'spam2 = []', p_close, '1.9', ']',
+               'spam2 = []', '1.10'),
+              (1, 1, 1, 'eggs2 = {}', p_close, '1.9', '}',
+               'eggs2 = {}', '1.10'),
+              (1, 1, 1, "color = ", t_open, '1.8', "'",
+               "color = ''", '1.9'),
+              (1, 1, 1, "velocity = ", t_open, '1.11', '"',
+               'velocity = ""', '1.12'),
+              (1, 1, 1, "more_spam = ''", t_open, '1.14', "'",
+               "more_spam = ''''''", '1.15'),
+              (1, 1, 1, 'more_eggs = ""', t_open, '1.14', '"',
+               'more_eggs = """"""', '1.15'),
+              (1, 1, 1, "more_spam2 = ''''''", t_open, '1.16', "'",
+               "more_spam2 = ''''''", '1.17'),
+              (1, 1, 1, 'more_eggs2 = """"""', t_open, '1.16', '"',
+               'more_eggs2 = """"""', '1.17'),
+              (0, 1, 1, 'no_spam = ', p_open, '1.10', '(',
+               'no_spam = (', '1.11'),
+              (1, 0, 1, 'no_velocity = ', t_open, '1.14', "'",
+               "no_velocity = '", '1.15'),
+              (1, 0, 1, 'no_more_eggs = ""', t_open, '1.17', '"',
+               'no_more_eggs = """', '1.18'),
+              (1, 1, 0, 'tinny = []', p_close, '1.9', ']',
+               'tinny = []]', '1.10'),
+              (1, 1, 0, 'gone = ""', t_open, '1.8', '"',
+               'gone = """"', '1.9')]:
+                    # reset text and self
+                    self.paren_close = paren_close_set
+                    self.tick_close = tick_close_set
+                    self.skip_closures = skip_closures_set
+                    self.text.delete('1.0', 'end')
+                    # write text, move to current position, write character
+                    self.text.insert('1.0', insert)
+                    self.text.mark_set('insert', pos)
+                    event = MockEvent(char)
+                    func(self, event)
+                    p = self.text.index('insert')
+                    self.text.insert(p, char)
+                    # checking position and text at the same time
+                    # makes it easier to spot where errors occur
+                    p = self.text.index('insert')
+                    actual = self.text.get('1.0', 'end')
+                    self.assertTupleEqual((actual, p), (result+'\n', posend))
+
+if __name__ == '__main__':
+    unittest.main(verbosity=2)