-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-46431: Add example of subclassing ExceptionGroup. Document the me… #30852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iritkatriel
merged 5 commits into
python:main
from
iritkatriel:bpo-46431-subclassing-ExceptionGroup
Jan 24, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
50a505d
bpo-46431: Add example of subclassing ExceptionGroup. Document the me…
iritkatriel 7d3e873
fix backticks
iritkatriel 25310fd
self --> cls
iritkatriel 112272c
remove repl prompts
iritkatriel a14a689
fix indentation of attribute and method descriptions
iritkatriel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is in the docs for the
derive
method, but I think it makes more sense in the top-level description of the class (here: https://docs.python.org/3.11/library/exceptions.html#BaseExceptionGroup).Also, I noticed the descriptions of the methods are underindented in the docs. They should be indented by one more level, as you did for the attributes above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this belong at a higher level. On the other hand I didn't want to present it in the beginning before we even mentioned derive(). Would it work if I indent everything as you suggest, and leave the full subclassing example at its current indentation level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea