bpo-46431: Add example of subclassing ExceptionGroup. Document the me… #30852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssage and exceptions attributes.
encukou
reviewed
Jan 24, 2022
Co-authored-by: Petr Viktorin <encukou@gmail.com>
| @@ -921,6 +930,21 @@ their subgroups based on the types of the contained exceptions. | |||
| >>> MyGroup("eg", [ValueError(1), TypeError(2)]).split(TypeError) | |||
| (MyGroup('eg', [TypeError(2)]), MyGroup('eg', [ValueError(1)])) | |||
|
|
|||
| Note that :exc:`BaseExceptionGroup` defines :meth:`__new__`, so | |||
There was a problem hiding this comment.
This block is in the docs for the derive method, but I think it makes more sense in the top-level description of the class (here: https://docs.python.org/3.11/library/exceptions.html#BaseExceptionGroup).
Also, I noticed the descriptions of the methods are underindented in the docs. They should be indented by one more level, as you did for the attributes above.
There was a problem hiding this comment.
I agree this belong at a higher level. On the other hand I didn't want to present it in the beginning before we even mentioned derive(). Would it work if I indent everything as you suggest, and leave the full subclassing example at its current indentation level?
JelleZijlstra
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssage and exceptions attributes.
https://bugs.python.org/issue46431