bpo-46431: Add example of subclassing ExceptionGroup. Document the me… #30852
Conversation
…ssage and exceptions attributes.
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
Thanks! This is much clearer.
Nitpick: since there's no output, could you remove the REPL prompts?
Co-authored-by: Petr Viktorin <encukou@gmail.com>
| >>> MyGroup("eg", [ValueError(1), TypeError(2)]).split(TypeError) | ||
| (MyGroup('eg', [TypeError(2)]), MyGroup('eg', [ValueError(1)])) | ||
|
|
||
| Note that :exc:`BaseExceptionGroup` defines :meth:`__new__`, so |
There was a problem hiding this comment.
This block is in the docs for the derive method, but I think it makes more sense in the top-level description of the class (here: https://docs.python.org/3.11/library/exceptions.html#BaseExceptionGroup).
Also, I noticed the descriptions of the methods are underindented in the docs. They should be indented by one more level, as you did for the attributes above.
There was a problem hiding this comment.
I agree this belong at a higher level. On the other hand I didn't want to present it in the beginning before we even mentioned derive(). Would it work if I indent everything as you suggest, and leave the full subclassing example at its current indentation level?
5 participants
…ssage and exceptions attributes.
https://bugs.python.org/issue46431