Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729) #27744

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 12, 2021

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com

https://bugs.python.org/issue44885

…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@isidentical
Copy link
Member

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

@pablogsal
Copy link
Member Author

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

We have one that probably will fail soon :(

I will fix it if I can, but I have already removed some tests to avoid failures. If I cannot fix it we may need to revert :(

@pablogsal
Copy link
Member Author

Fixed by #27749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants