[3.8] bpo-42773: fix tests not being run on pushes (GH-24004)#24010
Closed
miss-islington wants to merge 1 commit intopython:3.8from
Closed
[3.8] bpo-42773: fix tests not being run on pushes (GH-24004)#24010miss-islington wants to merge 1 commit intopython:3.8from
miss-islington wants to merge 1 commit intopython:3.8from
Conversation
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
Mariatta
approved these changes
Dec 30, 2020
Contributor
Author
|
@FFY00: Status check is done, and it's a failure ❌ . |
Member
|
Tests failed on test_nntplib. I re-run jobs. |
Contributor
Author
|
@FFY00: Status check is done, and it's a failure ❌ . |
1 similar comment
Contributor
Author
|
@FFY00: Status check is done, and it's a failure ❌ . |
Member
|
Not good. test_nntplib failed again. |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.
Signed-off-by: Filipe Laíns lains@riseup.net
(cherry picked from commit 4ac923f)
Co-authored-by: Filipe Laíns lains@riseup.net
https://bugs.python.org/issue42773