bpo-42773: fix tests not being run on pushes#24004
Merged
miss-islington merged 1 commit intopython:masterfrom Dec 30, 2020
Merged
bpo-42773: fix tests not being run on pushes#24004miss-islington merged 1 commit intopython:masterfrom
miss-islington merged 1 commit intopython:masterfrom
Conversation
Mariatta
approved these changes
Dec 30, 2020
Member
Mariatta
left a comment
Mariatta
left a comment
There was a problem hiding this comment.
Thanks for fixing. I think the news file is not needed though. Would you be able to remove it. I have already applied the "skip news" label.
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net>
Member
Author
|
Done 😊 |
Member
|
Thanks! |
Contributor
|
Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-24010 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 30, 2020
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
|
GH-24011 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 30, 2020
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
Contributor
|
Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-24437 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 3, 2021
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 3, 2021
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
|
GH-24438 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 3, 2021
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington
added a commit
that referenced
this pull request
Feb 3, 2021
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net>
Contributor
|
Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-92341 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2022
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <lains@riseup.net>
ned-deily
pushed a commit
that referenced
this pull request
May 6, 2022
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 4ac923f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.
Signed-off-by: Filipe Laíns lains@riseup.net
https://bugs.python.org/issue42773
Automerge-Triggered-By: GH:Mariatta