Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] bpo-38870: Extend subject of ast.unparse warnings (GH-21053) #21191

Merged
merged 1 commit into from
Jun 28, 2020
Merged

[3.9] bpo-38870: Extend subject of ast.unparse warnings (GH-21053) #21191

merged 1 commit into from
Jun 28, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 28, 2020 •
edited by bedevere-bot
Loading

  • Mention that some compiler optimizations might not roundtrip
    exactly (such as constant tuples and frozensets).

  • Add a warning about it might raise RecursionError on very
    complex expressions due to recursive unparsing aspect of ast.unparse
    (cherry picked from commit 8df1016)

Co-authored-by: Batuhan Taskaya batuhanosmantaskaya@gmail.com

https://bugs.python.org/issue38870

@isidentical @pablogsal
[3.9] bpo-38870: Extend subject of ast.unparse warnings (pythonGH-21053)
2d3ff39 
- Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).

- Add a warning about it might raise RecursionError on very
complex expressions due to recursive unparsing aspect of ast.unparse
(cherry picked from commit 8df1016)

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jun 28, 2020
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting core review labels Jun 28, 2020
@isidentical
Copy link
Member

isidentical commented Jun 28, 2020 •
edited
Loading

I was about to backport but looks like you're way faster than me 😊

@pablogsal
Copy link
Member Author

I was about to backport but looks like you're way faster than me

😉

@pablogsal pablogsal merged commit 6e39999 into python:3.9 Jun 28, 2020
@pablogsal pablogsal deleted the backport-8df1016-3.9 branch June 28, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot