Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38870: Extend subject of ast.unparse warnings #21053

Merged
merged 1 commit into from
Jun 28, 2020
Merged

bpo-38870: Extend subject of ast.unparse warnings #21053

merged 1 commit into from
Jun 28, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Jun 22, 2020 •
edited by bedevere-bot
Loading

  • Mention that some compiler optimizations might not roundtrip
    exactly (such as constant tuples and frozensets).

  • Add a warning about it might raise RecursionError on very
    complex expressions due to recursive unparsing aspect of ast.unparse

https://bugs.python.org/issue38870

@isidentical
bpo-38870: Extend subject of ast.unparse warnings
5f55bd4 
- Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).

- Add a warning about it might raise RecursionError on very
complex expressions due to recursive unparsing aspect of ast.unparse
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 22, 2020
@isidentical isidentical requested a review from pablogsal June 22, 2020 10:41
@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Jun 28, 2020
@pablogsal pablogsal merged commit 8df1016 into python:master Jun 28, 2020
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @isidentical and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8df1016e2ef8c0a9f4d15bf7894c284295c99d9f 3.9

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Jun 28, 2020
@isidentical @pablogsal
[3.9] bpo-38870: Extend subject of ast.unparse warnings (pythonGH-21053)
2d3ff39 
- Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).

- Add a warning about it might raise RecursionError on very
complex expressions due to recursive unparsing aspect of ast.unparse
(cherry picked from commit 8df1016)

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 28, 2020
@bedevere-bot
Copy link

GH-21191 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Jun 28, 2020
@pablogsal
[3.9] bpo-38870: Extend subject of ast.unparse warnings (GH-21053) (G…
6e39999 
…H-21191)

- Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).

- Add a warning about it might raise RecursionError on very
complex expressions due to the recursive unparsing aspect of ast.unparse
(cherry picked from commit 8df1016)
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@isidentical @fasihahmad
bpo-38870: Extend subject of ast.unparse warnings (pythonGH-21053)
f9218c0 
- Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).

- Add a warning about it might raise RecursionError on very
complex expressions due to recursive unparsing aspect of ast.unparse
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@isidentical @arun-mani-j
bpo-38870: Extend subject of ast.unparse warnings (pythonGH-21053)
ad34601 
- Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).

- Add a warning about it might raise RecursionError on very
complex expressions due to recursive unparsing aspect of ast.unparse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isidentical @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni