bpo-39681: Fix C pickle regression with minimal file-like objects #18592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression where the C pickle module wouldn't allow unpickling from a file-like object that doesn't expose a readinto() method.
|
cc @pierreglaser and @ogrisel if you want to give this a quick look. |
Codecov Report
@@ Coverage Diff @@
## master #18592 +/- ##
===========================================
+ Coverage 82.11% 83.13% +1.01%
===========================================
Files 1956 1571 -385
Lines 589402 414817 -174585
Branches 44458 44458
===========================================
- Hits 484012 344841 -139171
+ Misses 95739 60348 -35391
+ Partials 9651 9628 -23
Continue to review full report at Codecov.
|
pitrou
commented
Feb 21, 2020
| return bad_readline(); | ||
| } | ||
| if (_Unpickler_SkipConsumed(self) < 0) { | ||
| return -1; | ||
| } | ||
|
|
||
| if (!self->readinto) { | ||
| /* readinto() not supported on file-like object, fall back to read() | ||
| * and copy into destination buffer (bpo-39681) */ |
There was a problem hiding this comment.
Perhaps we should deprecate this fallback path in 3.9?
|
@ambv: Please replace |
|
GH-18630 is a backport of this pull request to the 3.8 branch. |
|
LGTM. Thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression where the C pickle module wouldn't allow unpickling from a
file-like object that doesn't expose a readinto() method.
https://bugs.python.org/issue39681