Skip to content

[3.8] bpo-39681: Fix C pickle regression with minimal file-like objects (GH-18592) #18630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2020
Merged

[3.8] bpo-39681: Fix C pickle regression with minimal file-like objects (GH-18592) #18630

merged 1 commit into from
Feb 23, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 23, 2020 •
edited by bedevere-bot
Loading

Fix a regression where the C pickle module wouldn't allow unpickling from a
file-like object that doesn't expose a readinto() method.
(cherry picked from commit 9f37872)

Co-authored-by: Antoine Pitrou antoine@python.org

https://bugs.python.org/issue39681

@pitrou @miss-islington
bpo-39681: Fix C pickle regression with minimal file-like objects (py…
24ad531 
…thonGH-18592)

Fix a regression where the C pickle module wouldn't allow unpickling from a
file-like object that doesn't expose a readinto() method.
(cherry picked from commit 9f37872)

Co-authored-by: Antoine Pitrou <antoine@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2020
Merged
@miss-islington
Copy link
Contributor Author

@pitrou and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv merged commit b19f7ec into python:3.8 Feb 23, 2020
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-9f37872-3.8 branch February 23, 2020 22:53
@miss-islington
Copy link
Contributor Author

@pitrou and @ambv: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@pitrou and @ambv: Status check is done, and it's a success ✅ .

farazs-github pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Issue python#18630: MINGW: exclude unix only modules
4c64d35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @bedevere-bot @ambv @the-knights-who-say-ni @pitrou