Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-10945: Drop support for bdist_wininst on non-Windows systems #14506

Merged
merged 4 commits into from
Jul 1, 2019
Merged

bpo-10945: Drop support for bdist_wininst on non-Windows systems #14506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70d3918
bpo-10945: Drop support for bdist_wininst on non-Windows systems
hroncok Jul 1, 2019
cf0cbb0
fixup! bpo-10945: Drop support for bdist_wininst on non-Windows systems
hroncok Jul 1, 2019
11137fc
fixup! bpo-10945: Drop support for bdist_wininst on non-Windows systems
hroncok Jul 1, 2019
8f4e424
fixup! bpo-10945: Drop support for bdist_wininst on non-Windows systems
hroncok Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/distutils/builtdist.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,8 @@ or the :command:`bdist` command with the :option:`!--formats` option::

If you have a pure module distribution (only containing pure Python modules and
packages), the resulting installer will be version independent and have a name
like :file:`foo-1.0.win32.exe`. These installers can even be created on Unix
platforms or Mac OS X.
like :file:`foo-1.0.win32.exe`. Note that creating ``wininst`` binary
distributions in only supported on Windows systems.

If you have a non-pure distribution, the extensions can only be created on a
Windows platform, and will be Python version dependent. The installer filename
Expand Down
3 changes: 3 additions & 0 deletions Lib/distutils/command/bdist_wininst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ class bdist_wininst(Command):
boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize',
'skip-build']

# bpo-10945: bdist_wininst requires mbcs encoding only available on Windows
_unsupported = (sys.platform != "win32")

def initialize_options(self):
self.bdist_dir = None
self.plat_name = None
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Officially drop support for creating bdist_wininst installers on non-Windows
systems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it wasn't supported previously, so I don't think that we even have to document the change. But I'm fine with keeping this changelog entry if you prefer.