bpo-10945: Drop support for bdist_wininst on non-Windows systems #14506
Conversation
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on py3k. Here we document that bdist_wininst is only supported on Windows and we mark it _unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.
Doc/distutils/builtdist.rst
Outdated
| @@ -342,6 +341,9 @@ version number. This can be changed to another text by using the | |||
| The installer file will be written to the "distribution directory" --- normally | |||
| :file:`dist/`, but customizable with the :option:`!--dist-dir` option. | |||
|
|
|||
| .. versionchanged:: 3.9 | |||
There was a problem hiding this comment.
Please remove this note.
I don't see why this change should be Python 3.9 only: mbcs encoding was never available on platforms other than Windows. If we make a change, I suggest to make it in 3.7, 3.8 and master branches.
| @@ -55,6 +56,8 @@ class bdist_wininst(Command): | |||
| boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize', | |||
| 'skip-build'] | |||
|
|
|||
| _unsupported = platform.system() != "Windows" | |||
There was a problem hiding this comment.
I suggest:
# bpo-10945: bdist_wininst requires mbcs encoding which is only available on Windows
_unsupported = (sys.platform != "win32")
| @@ -0,0 +1,2 @@ | |||
| Officially drop support for creating bdist_wininst installers on non-Windows | |||
| systems. | |||
There was a problem hiding this comment.
Technically, it wasn't supported previously, so I don't think that we even have to document the change. But I'm fine with keeping this changelog entry if you prefer.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
|
An idea: Don't install the relevant exe files on non-Windows? |
I would prefer to have a separated PR for that. |
|
I'm having trouble backporting to |
…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
GH-14509 is a backport of this pull request to the 3.7 branch. |
…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
GH-14510 is a backport of this pull request to the 3.8 branch. |
…14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
…14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.
…honGH-14506) bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3. Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests. Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.
bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on py3k.
Here we document that bdist_wininst is only supported on Windows
and we mark it _unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.
https://bugs.python.org/issue10945