gh-142784: Make the asyncio REPL call .close() on the loop#142785
Merged
kumaraditya303 merged 10 commits intopython:mainfrom Dec 18, 2025
Merged
gh-142784: Make the asyncio REPL call .close() on the loop#142785kumaraditya303 merged 10 commits intopython:mainfrom
.close() on the loop#142785kumaraditya303 merged 10 commits intopython:mainfrom
Conversation
Member
Author
|
I'm happy to have confirmed that this fixes the problem in GH-140288. I'll add a test and we're ready. |
Member
Author
|
In the meantime -- @graingert, do you think this is the good direction? |
johnslavik
commented
Dec 16, 2025
Misc/NEWS.d/next/Library/2025-12-16-04-39-27.gh-issue-142784.HBGJag.rst
Outdated
Show resolved
Hide resolved
johnslavik
changed the title
asyncio.Runner in the asyncio REPL.close() on the loop
johnslavik
commented
Dec 18, 2025
johnslavik
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
Member
Author
|
@kumaraditya303 I've dropped |
Misc/NEWS.d/next/Library/2025-12-16-04-39-27.gh-issue-142784.HBGJag.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303
approved these changes
Dec 18, 2025
Member
Author
|
@ZeroIntensity |
ZeroIntensity
added
needs backport to 3.13
|
Thanks @johnslavik for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @johnslavik for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2025
…ythonGH-142785) (cherry picked from commit ddfc155) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2025
…ythonGH-142785) (cherry picked from commit ddfc155) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
GH-142932 is a backport of this pull request to the 3.13 branch. |
|
GH-142933 is a backport of this pull request to the 3.14 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 18, 2025
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 18, 2025
cocolato
pushed a commit
to cocolato/cpython
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.