gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL#140288
gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL#140288johnslavik wants to merge 43 commits intopython:mainfrom
PYTHONSTARTUP script exceptions in the asyncio REPL#140288Conversation
|
Please merge #140298 first. |
|
Looks like I was confused about the regression -- that's good news! This will have to wait until the loop is properly closed in the asyncio REPL. |
It does! Cool! |
This reverts commit 875fd2a.
| except SystemExit: | ||
| raise |
There was a problem hiding this comment.
I really don't like this, but it resembles the original behavior of the REPLs -- see GH-143023.
I don't think this is correct, but it's not super clear to me, so please chime in to GH-143023 to put your two cents in.
| except SystemExit: | |
| raise | |
| # TODO: Revisit in GH-143023 | |
| except SystemExit: | |
| raise |
There was a problem hiding this comment.
GH-143023 is also why I didn't add a test for this.
There was a problem hiding this comment.
We've got some good news, this is not bad! I'll add a test shortly.
|
I'll see if I can simplify this. I think the tests are slightly overcomplicated. |
johnslavik
left a comment
There was a problem hiding this comment.
I'll come back to this after completing GH-140648.
|
I've realized that this isn't testing what it is supposed to test. I'll come back to this later. |
This is generally a work in progress; tests are needed.
The asyncio patch is simple and ready.
PYTHONSTARTUPexceptions #140287