gh-127930: use explicit imports in tkinter.simpledialog#127931
Merged
hugovk merged 4 commits intopython:mainfrom Dec 14, 2025
Merged
gh-127930: use explicit imports in tkinter.simpledialog#127931hugovk merged 4 commits intopython:mainfrom
hugovk merged 4 commits intopython:mainfrom
Conversation
tungol
changed the title
Member
|
I hope, no one does |
Contributor
Author
|
I added |
picnixz
reviewed
Dec 15, 2024
Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rst
Outdated
Show resolved
Hide resolved
…sGnh9.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Member
|
LGTM. 👍 |
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 16, 2025
…#127931) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simpledialog was overlooked when all the other tkinter submodules were updated to use explicit imports in #14864. This MR fixes that.
This is relevant to typeshed, where stubtest detects the extra constants imported into tkinter.simpledialog and emits a warning that they're not present in the stubs. Star imports in the stdlib usually indicate an intention to re-export.
I don't think this is user-facing enough to need a NEWS entry, but I'm happy to add one if anyone thinks otherwise.