Skip to content

Explicit imports in tkinter.simpledialog #127930

Open
@tungol

Description

@tungol

Feature or enhancement

Proposal:

In #14864, most of the tkinter submodules were changed to use explicit imports instead of from tkinter import *. tkinter.simpledialog didn't get that update, and is the only one still using the star import. I think we should update simpledialog to use explicit imports as well.

This is best practice, and also relevant to typeshed, where stubtest detects the extra constants imported into tkinter.simpledialog and emits a warning that they're not present in the stubs.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibPython modules in the Lib dirtype-featureA feature request or enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions