Doc: C API: Move tp_dealloc paragraph to tp_dealloc section
#125737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like commit 43cf44d (pythongh-31501) accidentally moved the paragraph to the `tp_finalize` section when the intent was to move it to the `tp_dealloc` section (according to the commit message). Also: * Convert the paragraph to a warning. * Apply the appropriate font style to `tp_dealloc`. * Unlinkify the first mention of `tp_dealloc` since the paragraph is already in the `tp_dealloc` section.
bedevere-app
bot
added
docs
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JelleZijlstra
approved these changes
Oct 21, 2024
JelleZijlstra
added
needs backport to 3.12
|
Thanks @rhansen for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2024
…onGH-125737) It looks like commit 43cf44d (pythongh-31501) accidentally moved the paragraph to the `tp_finalize` section when the intent was to move it to the `tp_dealloc` section (according to the commit message). (cherry picked from commit d880c83) Co-authored-by: Richard Hansen <rhansen@rhansen.org> Also: * Convert the paragraph to a warning. * Apply the appropriate font style to `tp_dealloc`. * Unlinkify the first mention of `tp_dealloc` since the paragraph is already in the `tp_dealloc` section.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2024
…onGH-125737) It looks like commit 43cf44d (pythongh-31501) accidentally moved the paragraph to the `tp_finalize` section when the intent was to move it to the `tp_dealloc` section (according to the commit message). (cherry picked from commit d880c83) Co-authored-by: Richard Hansen <rhansen@rhansen.org> Also: * Convert the paragraph to a warning. * Apply the appropriate font style to `tp_dealloc`. * Unlinkify the first mention of `tp_dealloc` since the paragraph is already in the `tp_dealloc` section.
|
GH-125798 is a backport of this pull request to the 3.13 branch. |
|
GH-125799 is a backport of this pull request to the 3.12 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 21, 2024
GH-125737) (#125799) Doc: C API: Move `tp_dealloc` paragraph to `tp_dealloc` section (GH-125737) It looks like commit 43cf44d (gh-31501) accidentally moved the paragraph to the `tp_finalize` section when the intent was to move it to the `tp_dealloc` section (according to the commit message). (cherry picked from commit d880c83) Co-authored-by: Richard Hansen <rhansen@rhansen.org>
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 21, 2024
GH-125737) (#125798) It looks like commit 43cf44d (gh-31501) accidentally moved the paragraph to the `tp_finalize` section when the intent was to move it to the `tp_dealloc` section (according to the commit message). (cherry picked from commit d880c83) Co-authored-by: Richard Hansen <rhansen@rhansen.org>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…on#125737) It looks like commit 43cf44d (pythongh-31501) accidentally moved the paragraph to the `tp_finalize` section when the intent was to move it to the `tp_dealloc` section (according to the commit message). Also: * Convert the paragraph to a warning. * Apply the appropriate font style to `tp_dealloc`. * Unlinkify the first mention of `tp_dealloc` since the paragraph is already in the `tp_dealloc` section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like commit 43cf44d (gh-31501) accidentally moved the paragraph to the
tp_finalizesection when the intent was to move it to thetp_deallocsection (according to the commit message).Also:
tp_dealloc.tp_deallocsince the paragraph is already in thetp_deallocsection.📚 Documentation preview 📚: https://cpython-previews--125737.org.readthedocs.build/