Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] Doc: C API: Move tp_dealloc paragraph to tp_dealloc section (GH-125737) #125798

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 21, 2024

It looks like commit 43cf44d
(gh-31501) accidentally moved the paragraph to the tp_finalize
section when the intent was to move it to the tp_dealloc section
(according to the commit message).

(cherry picked from commit d880c83)

Co-authored-by: Richard Hansen rhansen@rhansen.org
Also: * Convert the paragraph to a warning.

  • Apply the appropriate font style to tp_dealloc.
  • Unlinkify the first mention of tp_dealloc since the paragraph is
    already in the tp_dealloc section.

📚 Documentation preview 📚: https://cpython-previews--125798.org.readthedocs.build/

…onGH-125737)

It looks like commit 43cf44d
(pythongh-31501) accidentally moved the paragraph to the `tp_finalize`
section when the intent was to move it to the `tp_dealloc` section
(according to the commit message).

(cherry picked from commit d880c83)

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
Also: * Convert the paragraph to a warning.
  * Apply the appropriate font style to `tp_dealloc`.
  * Unlinkify the first mention of `tp_dealloc` since the paragraph is
    already in the `tp_dealloc` section.
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 21, 2024
@JelleZijlstra JelleZijlstra merged commit 2e56526 into python:3.13 Oct 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants