GH-123232: Factor BINARY_SLICE and STORE_SLICE to handle stats properly for tier 2. #123381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pairs, to handle stats properly in tier 2
markshannon
changed the title
iritkatriel
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JIT with stats build that was broken by #123236
Refactors BINARY_SLICE into _SPECIALIZE_BINARY_SLICE and _BINARY_SLICE micro-op pairs.
Likewise for STORE_SLICE.
This doesn't do any specialization, but factoring the code this way tells the code generator to emit only the non-specializing part for tier 2.