Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-123232: Fix "not specialized" stats #123236

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 22, 2024

  • Add deferred stats for BINARY_SLICE and STORE_SLICE both of which we regard as specializable, even though we don't specialize them yet.
  • Don't count branches as "not specialized"

@markshannon markshannon requested a review from mdboom August 22, 2024 15:49
@markshannon markshannon changed the title GH-123232: Fix not specialized stats GH-123232: Fix "not specialized" stats Aug 22, 2024
@markshannon markshannon merged commit 0b0f7be into python:main Aug 23, 2024
59 checks passed
@brandtbucher
Copy link
Member

@markshannon, this broke JIT stats builds since OPCODE_DEFERRED_INC uses the tier one interpreter's opcode local variable, which is meaningless in tier two. Should these new uses be guarded with #if TIER_ONE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants