GH-103379: Fix up old tests for pathlib.PurePath._parse_path#103380
Merged
barneygale merged 4 commits intopython:mainfrom Apr 9, 2023
Merged
GH-103379: Fix up old tests for pathlib.PurePath._parse_path#103380barneygale merged 4 commits intopython:mainfrom
pathlib.PurePath._parse_path#103380barneygale merged 4 commits intopython:mainfrom
Conversation
These tests now make assertions about the public `PurePath.drive`, `root` and `parts` attributes, rather than an internal method. They're moved out of the `_BaseFlavourTest`, `PosixFlavourTest` and `NTFlavourTest` classes, which are removed.
terryjreedy
reviewed
Apr 8, 2023
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I have seen discussions of whether or not to write tests for private functions and am somewhat on the fence. Since you propose to merely change the existing tests, rather than delete them, and the change makes it clearer (to me) what is really being tested, I approve.
terryjreedy
reviewed
Apr 8, 2023
terryjreedy
changed the title
pathlib.PurePath._parse_parts()pathlib.PurePath._parse_path
terryjreedy
reviewed
Apr 8, 2023
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
The calls with first and last args being flat tuples looks fine. This looks better to me than before.
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
AlexWaygood
approved these changes
Apr 9, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks great to me -- thanks @barneygale!
Contributor
Author
|
Thank you both! |
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…ythonGH-103380) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
…ythonGH-103380) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests now make assertions about the public
PurePath.drive,rootandpartsattributes, rather than an internal method. They're moved out of the_BaseFlavourTest,PosixFlavourTestandNTFlavourTestclasses, which are removed.