Skip to content

Vestigial pathlib 'flavour' tests make assertions about internal method #103379

Closed
Closed
Vestigial pathlib 'flavour' tests make assertions about internal method#103379
Labels
3.12only security fixestestsTests in the Lib/test dirtopic-pathlibtype-bugAn unexpected behavior, bug, or error

Description

@barneygale
barneygale
opened on Apr 8, 2023

Pathlib used to contain internal "flavour classes" with their own test suites. These were removed in a68e585 (#31691) and e5b08dd (#101002) along with most of their tests. Only the tests for the internal _parse_path() method remain now.

These tests make assertions about an internal method that we're liable to change, rename or remove in future. They should instead make assertions about the public PurePath.drive, root and parts attributes. I think.

Linked PRs

Activity

  1. barneygale
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    3.12only security fixes
    topic-pathlib
    on Apr 8, 2023
  2. barneygale
    added 2 commits that reference this issue on Apr 8, 2023

    pythonGH-103379: Fix up old tests for `pathlib.PurePath._parse_parts()`

    2fc2192

    GH-103379: Fix up old tests for `pathlib.PurePath._parse_path` (GH-10…

    0a675f4

  3. barneygale commented on Apr 9, 2023

    @barneygale
    barneygale
    on Apr 9, 2023
    ContributorAuthor

    Fixed in 0a675f4

  4. barneygale
    closed this as completedon Apr 9, 2023
  5. warsaw
    added a commit that references this issue on Apr 11, 2023

    pythonGH-103379: Fix up old tests for `pathlib.PurePath._parse_path` (p…

    d05e4bc
  6. aisk
    added a commit that references this issue on Apr 18, 2023

    pythonGH-103379: Fix up old tests for `pathlib.PurePath._parse_path` (p…

    275f466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixestestsTests in the Lib/test dirtopic-pathlibtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions