Skip to content

bpo-25416: add aliases for cp874 and mac_cyrillic encodings #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-25416: add aliases for cp874 and mac_cyrillic encodings #10237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/encodings/aliases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,10 @@
'csibm869' : 'cp869',
'ibm869' : 'cp869',

# cp874 codec
'windows_874' : 'cp874',


# cp932 codec
'932' : 'cp932',
'ms932' : 'cp932',
Expand Down Expand Up @@ -439,6 +443,7 @@

# mac_cyrillic codec
'maccyrillic' : 'mac_cyrillic',
'x_mac_cyrillic' : 'mac_cyrillic',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why x_mac_cyrillic, but not x_mac_greek etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the issue was only about cyrillic. I think that we should implement all the aliases but I'm not sure if I should do it in a PR related to a issue that cited only those two. I can implement the others if you think that's ok to do it in this PR


# mac_greek codec
'macgreek' : 'mac_greek',
Expand Down