bpo-25416: add aliases for cp874 and mac_cyrillic encodings#10237
bpo-25416: add aliases for cp874 and mac_cyrillic encodings#10237fbidu wants to merge 1 commit intopython:mainfrom
Conversation
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Neither cp874 nor mac_cyrillic are mentioned on bpo-18624.
|
|
||
| # mac_cyrillic codec | ||
| 'maccyrillic' : 'mac_cyrillic', | ||
| 'x_mac_cyrillic' : 'mac_cyrillic', |
There was a problem hiding this comment.
Why x_mac_cyrillic, but not x_mac_greek etc?
There was a problem hiding this comment.
Because the issue was only about cyrillic. I think that we should implement all the aliases but I'm not sure if I should do it in a PR related to a issue that cited only those two. I can implement the others if you think that's ok to do it in this PR
@serhiy-storchaka: |
|
Hi @serhiy-storchaka I just ran into a discussion about encoding and remembered of this PR. Do you think it still makes sense? Thanks |
|
This PR is stale because it has been open for 30 days with no activity. |
5 participants
Hi all!
This PR is about issue 25416 that is also closely related with with bpo-18624, both deal with missing aliases in the encondings module.
In this changeset I only tackled the lack of aliases reported on 25416 but I'm still missing tests on it. Reading through 18624, I noted that the file suggested by @bitdancer -
test_encodings.py- is missing. The author of 18624's patch added a test ontest_codecs.pybut that test seems incomplete.I'm considering add a test that checks if all the aliases are implemented and another one that checks if they are mapped to correct encodings. I'd be glad if a core dev could give me a guidance in how to proceed with that.
Thank you!
https://bugs.python.org/issue25416