Skip to content

GH-101369: Allow macros as family members#101399

Merged
gvanrossum merged 4 commits intopython:mainfrom
gvanrossum:fix-macros-good
Jan 30, 2023
Merged

GH-101369: Allow macros as family members#101399
gvanrossum merged 4 commits intopython:mainfrom
gvanrossum:fix-macros-good

Conversation

@gvanrossum
Copy link
Member

Fixes gh-101369.

@markshannon: You have to use macro here:

macro(BINARY_OP_ADD_FLOAT) = _BINARY_OP_ADD_FLOAT_CHECK + _BINARY_OP_ADD_FLOAT_ACTION;

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum
Copy link
Member Author

Thanks, I have a few updates in the pipeline. Will add those later.

@gvanrossum
Copy link
Member Author

This is all I was planning.

@gvanrossum gvanrossum merged commit 7a37523 into python:main Jan 30, 2023
@gvanrossum gvanrossum deleted the fix-macros-good branch January 30, 2023 19:24
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
Also check for instructions straddling families (this includes macro parts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bytecode interpreter generator should support composing instructions from parts.

3 participants