Bytecode interpreter generator should support composing instructions from parts.

[markshannon]

I.e. this should work as expected.

inst(BINARY_OP_ADD_FLOAT) = _BINARY_OP_ADD_FLOAT_CHECK + _BINARY_OP_ADD_FLOAT_ACTION;

The suggested solution of using macro doesn't work.
I get the error:

./Python/bytecodes.c:171: Unknown instruction 'BINARY_OP_ADD_FLOAT' referenced in family 'binary_op'
./Python/bytecodes.c:171: Family 'binary_op' has unknown members: {'BINARY_OP_ADD_FLOAT'}

Linked PRs

• GH-101369: Allow macros as family members #101399

[gvanrossum]

Looks like I left some technical debt in macro handling. :-(

• check_families() needs to look for family members in macros
• map_families() needs store family back-links in macro parts
• Those two need to run after super and macro analysis
• macro prelude generation needs to avoid emitting duplicate declarations when input and output variable names overlap (this was a dumb oversight)
• add tests

[markshannon]

I would "macro" to go. Instructions defined by composing ops are instructions just as much as those defined by a blob of C code.
inst(FOO_AND_BAR) = FOO + BAR;
Could you add

• Rename macro as inst, as they are instructions.

to the end of your list?

[gvanrossum]

We’ve talked about that before, it would get a red squiggle in VS Code. Other than that it’s doable. @brandtbucher ?