[3.11] gh-100750: pass encoding kwarg in lib/platform.py (GH-100751)

[miss-islington]

(cherry picked from commit 6b3993c)

Co-authored-by: Thomas Grainger tagrain@gmail.com
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Shantanu 12621235+hauntsaninja@users.noreply.github.com

• Issue: PEP 597: platform from_subprocess missing encoding kwarg #100750

[malemburg]

Shouldn't this instance of calling .check_output() also receive an encoding argument ?

https://github.com/python/cpython/blob/main/Lib/platform.py#L667

(in _syscmd_file())

[graingert]

Shouldn't this instance of calling .check_output() also receive an encoding argument ?

main/Lib/platform.py#L667

(in _syscmd_file())

@malemburg no, that uses the default text=False and then decodes the bytes object returned with latin-1:

cpython/Lib/platform.py

Lines 667 to 676 in 62251c3

	output = subprocess.check_output(['file', '-b', target],
	stderr=subprocess.DEVNULL,
	env=env)
	except (OSError, subprocess.CalledProcessError):
	return default
	if not output:
	return default
	# With the C locale, the output should be mostly ASCII-compatible.
	# Decode from Latin-1 to prevent Unicode decode error.
	return output.decode('latin-1')