gh-100750: pass encoding kwarg in lib/platform.py #100751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
graingert
commented
Jan 4, 2023
•
graingert
commented
- Issue: PEP 597: platform from_subprocess missing encoding kwarg #100750
graingert
force-pushed
the
pass-encoding-kwarg-in-platform
branch
from
1ac7321
to
e18da85
Compare
graingert
changed the title
methane
reviewed
Jan 5, 2023
Lib/platform.py
Outdated
| @@ -824,6 +825,7 @@ def from_subprocess(): | |||
| ['uname', '-p'], | |||
| stderr=subprocess.DEVNULL, | |||
| text=True, | |||
| encoding="locale", | |||
There was a problem hiding this comment.
I think uname output is not localized.
https://github.com/coreutils/coreutils/blob/8d4768c94d0fa9de545a6e1c370f9a6fae4cb3a7/src/uname.c#L314-L371
So we can use "utf-8" or "latin1" here.
graingert
changed the title
graingert
commented
Jan 5, 2023
Misc/NEWS.d/next/Library/2023-01-04-14-42-59.gh-issue-100750.iFJs5Y.rst
Outdated
Show resolved
Hide resolved
graingert
commented
Jan 5, 2023
methane
approved these changes
Jan 6, 2023
|
Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 20, 2023
) (cherry picked from commit 6b3993c) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-101207 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 21, 2023
(cherry picked from commit 6b3993c) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2023
) (cherry picked from commit 6b3993c) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-101644 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.