Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_free_threading with GIL #120659

Closed
nineteendo opened this issue Jun 17, 2024 · 2 comments
Closed

Skip test_free_threading with GIL #120659

nineteendo opened this issue Jun 17, 2024 · 2 comments
Labels
topic-free-threading type-feature A feature request or enhancement

Comments

@nineteendo
Copy link
Contributor

nineteendo commented Jun 17, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

test_free_threading shouldn't run when the GIL is enabled. It takes 2 minutes on the default build, making it the slowest test in the suite.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

Linked PRs
@nineteendo nineteendo added the type-feature A feature request or enhancement label Jun 17, 2024
@bedevere-app bedevere-app bot mentioned this issue Jun 17, 2024
Merged
@blhsing
Copy link
Contributor

blhsing commented Jun 18, 2024 •
edited
Loading

test_free_threading shouldn't run when the GIL is disabled.

I think you mean to say "should only run" rather than "shouldn't run".

vstinner pushed a commit that referenced this issue Jun 18, 2024
@nineteendo
gh-120659: Skip test_freethreading with GIL (#120660)
360f14a
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 18, 2024
@nineteendo @miss-islington
pythongh-120659: Skip test_freethreading with GIL (pythonGH-120660)
1eec326 
(cherry picked from commit 360f14a)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 18, 2024
Merged
@vstinner
Copy link
Member

Fixed by 360f14a.

@colesbury colesbury mentioned this issue Jun 18, 2024
Closed
vstinner pushed a commit that referenced this issue Jun 18, 2024
@miss-islington @nineteendo
[3.13] gh-120659: Skip test_freethreading with GIL (GH-120660) (#12…
4f4973d 
…0694)

gh-120659: Skip `test_freethreading` with GIL (GH-120660)
(cherry picked from commit 360f14a)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
picnixz pushed a commit to picnixz/cpython that referenced this issue Jun 19, 2024
@nineteendo @picnixz
pythongh-120659: Skip test_freethreading with GIL (python#120660)
773c86d
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@nineteendo @mrahtz
pythongh-120659: Skip test_freethreading with GIL (python#120660)
f6f76d1
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@nineteendo @noahbkim
pythongh-120659: Skip test_freethreading with GIL (python#120660)
fed6ee4
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@nineteendo @estyxx
pythongh-120659: Skip test_freethreading with GIL (python#120660)
ba3a072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @sobolevn @blhsing @nineteendo