-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120659: Skip test_freethreading
with GIL
#120660
Conversation
Co-authored-by: Victor Stinner <vstinner@python.org>
d5633ae
to
465759a
Compare
I fixed the co-author message. |
I don't know test_freethreading. I don't know if it makes sense to run these tests with the GIL enabled. |
This comment was marked as resolved.
This comment was marked as resolved.
There is some value to running these tests on with the GIL enabled, but not enough to justify the time they're taking. If we make the tests faster, we can reconsider re-enabling them for the default build. |
Thanks @nineteendo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
(cherry picked from commit 360f14a) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
GH-120694 is a backport of this pull request to the 3.13 branch. |
Ok, in that case, I merge the change. Thanks @nineteendo. |
test_free_threading
with GIL #120659