Skip to content

Fix issue where PR without any description has its title edited #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

Mariatta
Copy link
Member

This came up in python/cpython#5291

The PR did not have any description, and the title was
edited to include the bpo number.
It caused a 500 error, because bedevere did not anticipate
this situation.

Updated the code so that it takes into consideration when the
body is empty.

@Mariatta
Copy link
Member Author

Thanks @brettcannon for the quick review!
But tests failed in 3.7 😥 ironically about asyncio stuff which I have no idea about @1st1
https://travis-ci.org/python/bedevere/jobs/332943652#L568

@brettcannon
Copy link
Member

Looks like the version of pytest-asyncio is too old to be compatible with the new async keyword change in 3.7.

@Mariatta Can you update the pytest-asyncio dependency in your PR and see if that fixes it? (Also feel free to update any other dependencies you want.)

@brettcannon
Copy link
Member

I also just turned on pyup.io on this repo to help prevent this issue going forward.

@brettcannon
Copy link
Member

Looks like pyup.io pushed #81 which should hopefully fix this.

@Mariatta
Copy link
Member Author

Thanks! I'll rebase to get the latest changes.

@brettcannon
Copy link
Member

#81 seems to do the trick, so probably just a merge off of master now will do the trick.

This came up in python/cpython#5291

The PR did not have any description, and the title was
edited to include the bpo number.
It caused a 500 error, because bedevere did not anticipate
this situation.

Updated the code so that it takes into consideration when the
body is empty.
@Mariatta Mariatta force-pushed the fix-pr-without-body branch from ec9fd14 to 10e5cd5 Compare January 24, 2018 20:07
@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         974    980    +6     
  Branches       56     56           
=====================================
+ Hits          974    980    +6
Impacted Files Coverage Δ
bedevere/bpo.py 100% <100%> (ø) ⬆️
tests/test_bpo.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229c1f1...10e5cd5. Read the comment docs.

@Mariatta Mariatta merged commit fd2df6d into master Jan 24, 2018
@Mariatta Mariatta deleted the fix-pr-without-body branch January 24, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants