bpo-32636: Fix @asyncio.coroutine debug mode bug exposed by #5250 #5291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
approved these changes
Jan 24, 2018
1st1
changed the title
1st1
changed the title
|
@Mariatta Sorry for bothering you, but what to do when Bedevere bot is stuck? :) |
|
I'll try closing and reopening again 😛 Sorry for the noise. |
Mariatta
changed the title
Mariatta
changed the title
|
Hmm not sure. I'll have to read code, once I have the chance a little later. |
1st1
changed the title
1st1
changed the title
|
@Mariatta should we re-submit this patch? |
|
Hold on before re-submitting a patch. I wanna debug bedevere and find out the issue. Thanks. Will keep you updated. |
|
There's 500 error with the webhook for this particular PR. I will take a further look. |
Mariatta
added a commit
to python/bedevere
that referenced
this pull request
Jan 24, 2018
This came up in python/cpython#5291 The PR did not have any description, and the title was edited to include the bpo number. It caused a 500 error, because bedevere did not anticipate this situation. Updated the code so that it takes into consideration when the body is empty.
|
I found the issue. The error arised in this specific situation of title edited and the PR does not contain any description ( |
|
Thanks so much, @Mariatta! |
Mariatta
added a commit
to python/bedevere
that referenced
this pull request
Jan 24, 2018
This came up in python/cpython#5291 The PR did not have any description, and the title was edited to include the bpo number. It caused a 500 error, because bedevere did not anticipate this situation. Updated the code so that it takes into consideration when the body is empty.
Mariatta
added a commit
to python/bedevere
that referenced
this pull request
Jan 24, 2018
This came up in python/cpython#5291 The PR did not have any description, and the title was edited to include the bpo number. It caused a 500 error, because bedevere did not anticipate this situation. Updated the code so that it takes into consideration when the body is empty.
Mariatta
changed the title
|
Thanks @Mariatta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None
https://bugs.python.org/issue32636