Skip to content

Remove py2k #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2020
Merged

Remove py2k #69

merged 3 commits into from
Apr 7, 2020

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 17, 2020

Wait for #68 to be merged first.

  • Drop Python 2 specific code
  • Run isort and drop flake8-import-order

My plan is to send another PR dropping more flake8 stuff and implement isort+black via pre-commit hooks and maybe a GH action.

@Conengmo
Copy link
Member

This change looks good so far. isort and black are great, let's use those.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

This change looks good so far. isort and black are great, let's use those.

I'm also planning on swapping versioneer for setuptools_scm. The former is unsupported and problematic with latest Python metadata standards.

@ocefpaf ocefpaf mentioned this pull request Feb 17, 2020
Closed
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

@Conengmo are you OK with the changes here?

@ocefpaf ocefpaf merged commit 6ac241a into python-visualization:master Apr 7, 2020
@ocefpaf ocefpaf deleted the remove_py2k branch April 7, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conengmo Conengmo Conengmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @Conengmo