-
Notifications
You must be signed in to change notification settings - Fork 68
New release #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release #68
Conversation
Looks good, and good that you added to the changelog. As you can see Travis is failing, it's on these two lines: Can you add that to this PR? Or leave it and I'll get it next time. |
I'm fixing those... |
@Conengmo are we dropping Python 2 in this release? If so I can send another PR before the release to remove it. |
Almost forgot but we are indeed dropping Python 2 with branca 0.4.0. There already was a PR for that: #56. This change updated |
Remove Python 2 code and workarounds. I'll send a PR soon. |
Let's get this release out before that then, so we don't have to hurry with reviewing and testing that. |
Oh and maybe good to add the Python 2 dropping to the changelog |
Sure.
I'll added that in a sec... |
This one is good to go it seems! 🚀 ? |
I'm done, no more commits :-) Feel free to merge if you are OK with the changes here. |
Great, time to release! |
@Conengmo I'll tag the release as soon as you review and merge this one.