Skip to content

New release #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2020
Merged

New release #68

merged 6 commits into from
Feb 17, 2020

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 17, 2020

@Conengmo I'll tag the release as soon as you review and merge this one.

@Conengmo
Copy link
Member

Conengmo commented Feb 17, 2020

Looks good, and good that you added to the changelog. As you can see Travis is failing, it's on these two lines:
https://github.com/python-visualization/branca/blob/master/branca/colormap.py#L200
https://github.com/python-visualization/branca/blob/master/branca/colormap.py#L382

Can you add that to this PR? Or leave it and I'll get it next time.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

Looks good, and good that you added to the changelog. As you can see Travis is failing, it's on these two lines:

I'm fixing those...

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

@Conengmo are we dropping Python 2 in this release? If so I can send another PR before the release to remove it.

@Conengmo
Copy link
Member

Almost forgot but we are indeed dropping Python 2 with branca 0.4.0. There already was a PR for that: #56. This change updated setup.py. What else should we do?

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

Almost forgot but we are indeed dropping Python 2 with branca 0.4.0. There already was a PR for that: #56. This change updated setup.py. What else should we do?

Remove Python 2 code and workarounds. I'll send a PR soon.

@Conengmo
Copy link
Member

Conengmo commented Feb 17, 2020

Let's get this release out before that then, so we don't have to hurry with reviewing and testing that.

@Conengmo
Copy link
Member

Oh and maybe good to add the Python 2 dropping to the changelog

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

Let's get this release out before that then, so we don't have to hurry with reviewing and testing that.

Sure.

Oh and maybe good to add the Python 2 dropping to the changelog

I'll added that in a sec...

@ocefpaf ocefpaf mentioned this pull request Feb 17, 2020
@Conengmo
Copy link
Member

This one is good to go it seems! 🚀 ?

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 17, 2020

This one is good to go it seems! ?

I'm done, no more commits :-)

Feel free to merge if you are OK with the changes here.

@Conengmo Conengmo merged commit cd22245 into python-visualization:master Feb 17, 2020
@Conengmo
Copy link
Member

Great, time to release!

@ocefpaf ocefpaf deleted the new_release branch February 17, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants