PR: Remove from ast import * from rope.base.ast

rope/base/arguments.py

@@ -1,5 +1,6 @@
+import ast
+
 import rope.base.evaluate
-from rope.base import ast
 
 
 class Arguments:

rope/base/ast.py

@@ -1,5 +1,4 @@
 import ast
-from ast import *  # noqa: F401,F403
 
 from rope.base import fscommands
 

rope/base/builtins.py

@@ -1,9 +1,10 @@
 """This module tries to support builtin types and functions."""
+import ast
 import inspect
 import io
 
 import rope.base.evaluate
-from rope.base import arguments, ast, pynames, pyobjects, utils
+from rope.base import arguments, pynames, pyobjects, utils
 
 
 class BuiltinModule(pyobjects.AbstractModule):

rope/base/evaluate.py

@@ -1,18 +1,20 @@
+import ast
 from operator import itemgetter
 from typing import Optional, Tuple
 
+import rope.base
 import rope.base.builtins
 import rope.base.pynames
 import rope.base.pyobjects
 from rope.base import (
     arguments,
-    ast,
     exceptions,
     nameanalyze,
     pyobjects,
     pyobjectsdef,
     worder,
 )
+from rope.base.ast import RopeNodeVisitor
 
 BadIdentifierError = exceptions.BadIdentifierError
 
@@ -49,7 +51,7 @@ def eval_str(holding_scope, name):
 def eval_str2(holding_scope, name):
     try:
         # parenthesizing for handling cases like 'a_var.\nattr'
-        node = ast.parse("(%s)" % name)
+        node = rope.base.ast.parse("(%s)" % name)
     except SyntaxError:
         raise BadIdentifierError("Not a resolvable python identifier selected.")
     return eval_node2(holding_scope, node)
@@ -157,7 +159,7 @@ def _find_module(self, module_name):
         )
 
 
-class StatementEvaluator(ast.RopeNodeVisitor):
+class StatementEvaluator(RopeNodeVisitor):
     def __init__(self, scope):
         self.scope = scope
         self.result = None

rope/base/nameanalyze.py

@@ -1,4 +1,6 @@
-from rope.base import ast
+import ast
+
+from rope.base.ast import RopeNodeVisitor
 
 
 def get_name_levels(node):
@@ -18,7 +20,7 @@ def get_name_levels(node):
     return visitor.names
 
 
-class _NodeNameCollector(ast.RopeNodeVisitor):
+class _NodeNameCollector(RopeNodeVisitor):
     def __init__(self, levels=None):
         self.names = []
         self.levels = levels

rope/base/oi/soa.py

@@ -1,7 +1,9 @@
-import rope.base.ast
+import ast
+
 import rope.base.oi.soi
 import rope.base.pynames
 from rope.base import arguments, evaluate, nameanalyze, pyobjects
+from rope.base.ast import RopeNodeVisitor
 
 
 def analyze_module(pycore, pymodule, should_analyze, search_subscopes, followed_calls):
@@ -31,11 +33,11 @@ def _follow(pyfunction):
             )
 
         visitor = SOAVisitor(pycore, pydefined, _follow if followed_calls else None)
-        for child in rope.base.ast.iter_child_nodes(pydefined.get_ast()):
+        for child in ast.iter_child_nodes(pydefined.get_ast()):
             visitor.visit(child)
 
 
-class SOAVisitor(rope.base.ast.RopeNodeVisitor):
+class SOAVisitor(RopeNodeVisitor):
     def __init__(self, pycore, pydefined, follow_callback=None):
         self.pycore = pycore
         self.pymodule = pydefined.get_module()
@@ -49,7 +51,7 @@ def _ClassDef(self, node):
         pass
 
     def _Call(self, node):
-        for child in rope.base.ast.iter_child_nodes(node):
+        for child in ast.iter_child_nodes(node):
             self.visit(child)
         primary, pyname = evaluate.eval_node2(self.scope, node.func)
         if pyname is None:
@@ -97,7 +99,7 @@ def _parameter_objects(self, pyfunction):
         ]
 
     def _AnnAssign(self, node):
-        for child in rope.base.ast.iter_child_nodes(node):
+        for child in ast.iter_child_nodes(node):
             self.visit(child)
         visitor = _SOAAssignVisitor()
         nodes = []
@@ -108,7 +110,7 @@ def _AnnAssign(self, node):
         self._evaluate_assign_value(node, nodes, type_hint=node.annotation)
 
     def _Assign(self, node):
-        for child in rope.base.ast.iter_child_nodes(node):
+        for child in ast.iter_child_nodes(node):
             self.visit(child)
         visitor = _SOAAssignVisitor()
         nodes = []
@@ -143,7 +145,7 @@ def __init__(self):
         self.nodes = []
 
     def _added(self, node, levels):
-        if isinstance(node, rope.base.ast.Subscript) and isinstance(
-            node.slice, (rope.base.ast.Index, rope.base.ast.expr)
+        if isinstance(node, ast.Subscript) and isinstance(
+            node.slice, (ast.Index, ast.expr)
         ):
             self.nodes.append((node, levels))

rope/base/oi/type_hinting/providers/numpydocstrings.py

@@ -3,9 +3,9 @@
 https://github.com/davidhalter/jedi/blob/b489019f5bd5750051122b94cc767df47751ecb7/jedi/evaluate/docstrings.py
 Thanks to @davidhalter for this utils under MIT License.
 """
+import ast
 import re
 
-from rope.base.ast import literal_eval
 from rope.base.oi.type_hinting.providers import docstrings
 
 try:
@@ -27,7 +27,7 @@ def __call__(self, docstring, param_name):
                     p_type = m.group(1)
 
                 if p_type.startswith("{"):
-                    types = {type(x).__name__ for x in literal_eval(p_type)}
+                    types = {type(x).__name__ for x in ast.literal_eval(p_type)}
                     return list(types)
                 else:
                     return [p_type]

rope/base/oi/type_hinting/providers/pep0484_type_comments.py

@@ -1,6 +1,5 @@
 import re
 
-from rope.base.oi.type_hinting import utils
 from rope.base.oi.type_hinting.providers import interfaces
 
 

rope/base/pyobjects.py

@@ -1,6 +1,7 @@
+import ast
 from typing import Optional
 
-from rope.base import ast, exceptions, utils
+from rope.base import exceptions, utils
 
 
 class PyObject:

rope/base/pyobjectsdef.py

@@ -1,3 +1,5 @@
+import ast
+
 import rope.base.builtins
 import rope.base.codeanalyze
 import rope.base.evaluate
@@ -6,14 +8,14 @@
 import rope.base.pyscopes
 from rope.base import (
     arguments,
-    ast,
     exceptions,
     fscommands,
     nameanalyze,
     pynamesdef,
     pyobjects,
     utils,
 )
+from rope.base.ast import RopeNodeVisitor
 
 
 class PyFunction(pyobjects.PyFunction):
@@ -177,7 +179,7 @@ def __init__(self, pycore, source=None, resource=None, force_errors=False):
                 raise
             else:
                 source = "\n"
-                node = ast.parse("\n")
+                node = rope.base.ast.parse("\n")
         self.source_code = source
         self.star_imports = []
         self.visitor_class = _GlobalVisitor
@@ -197,7 +199,7 @@ def _init_source(self, pycore, source_code, resource):
                     source_bytes = fscommands.unicode_to_file_data(source_code)
                 else:
                     source_bytes = source_code
-            ast_node = ast.parse(source_bytes, filename=filename)
+            ast_node = rope.base.ast.parse(source_bytes, filename=filename)
         except SyntaxError as e:
             raise exceptions.ModuleSyntaxError(filename, e.lineno, e.msg)
         except UnicodeDecodeError as e:
@@ -239,7 +241,7 @@ def __init__(self, pycore, resource=None, force_errors=False):
                 init_dot_py, force_errors=force_errors
             ).get_ast()
         else:
-            ast_node = ast.parse("\n")
+            ast_node = rope.base.ast.parse("\n")
         super().__init__(pycore, ast_node, resource)
 
     def _create_structural_attributes(self):
@@ -291,7 +293,7 @@ def get_name(self):
         return rope.base.libutils.modname(self.resource) if self.resource else ""
 
 
-class _AnnAssignVisitor(ast.RopeNodeVisitor):
+class _AnnAssignVisitor(RopeNodeVisitor):
     def __init__(self, scope_visitor):
         self.scope_visitor = scope_visitor
         self.assigned_ast = None
@@ -333,7 +335,7 @@ def _Slice(self, node):
         pass
 
 
-class _ExpressionVisitor(ast.RopeNodeVisitor):
+class _ExpressionVisitor(RopeNodeVisitor):
     def __init__(self, scope_visitor):
         self.scope_visitor = scope_visitor
 
@@ -360,7 +362,7 @@ def _NamedExpr(self, node):
         self.visit(node.value)
 
 
-class _AssignVisitor(ast.RopeNodeVisitor):
+class _AssignVisitor(RopeNodeVisitor):
     def __init__(self, scope_visitor):
         self.scope_visitor = scope_visitor
         self.assigned_ast = None

rope/base/pyscopes.py

@@ -1,5 +1,6 @@
+import ast
 import rope.base.builtins  # Use full qualification for clarity.
-from rope.base import ast, codeanalyze, exceptions, pynames, utils
+from rope.base import codeanalyze, exceptions, pynames, utils
 from rope.refactor import patchedast
 
 

rope/contrib/autoimport/__init__.py

@@ -1,6 +1,5 @@
 """AutoImport module for rope."""
 from .pickle import AutoImport as _PickleAutoImport
-from .sqlite import AutoImport as _SqliteAutoImport
 
 AutoImport = _PickleAutoImport
 

rope/contrib/autoimport/parse.py

@@ -4,13 +4,14 @@
 Can extract names from source code of a python file, .so object, or builtin module.
 """
 
+import ast
 import inspect
 import logging
 import pathlib
 from importlib import import_module
 from typing import Generator, List
 
-from rope.base import ast
+import rope.base
 
 from .defs import (
     ModuleCompiled,
@@ -45,7 +46,7 @@ def get_names_from_file(
 ) -> Generator[PartialName, None, None]:
     """Get all the names from a given file using ast."""
     try:
-        root_node = ast.parse(module.read_bytes())
+        root_node = rope.base.ast.parse(module.read_bytes())
     except SyntaxError as error:
         print(error)
         return

rope/contrib/finderrors.py

@@ -23,7 +23,10 @@
 * ... ;-)
 
 """
-from rope.base import ast, evaluate, pyobjects
+import ast
+
+from rope.base import evaluate, pyobjects
+from rope.base.ast import RopeNodeVisitor
 
 
 def find_errors(project, resource):
@@ -37,7 +40,7 @@ def find_errors(project, resource):
     return finder.errors
 
 
-class _BadAccessFinder(ast.RopeNodeVisitor):
+class _BadAccessFinder(RopeNodeVisitor):
     def __init__(self, pymodule):
         self.pymodule = pymodule
         self.scope = pymodule.get_scope()

rope/refactor/extract.py

@@ -1,8 +1,11 @@
+import ast
 import re
 from contextlib import contextmanager
 from itertools import chain
 
-from rope.base import ast, codeanalyze
+import rope.base
+from rope.base import codeanalyze
+from rope.base.ast import RopeNodeVisitor
 from rope.base.change import ChangeContents, ChangeSet
 from rope.base.exceptions import RefactoringError
 from rope.base.utils.datastructures import OrderedSet
@@ -514,7 +517,7 @@ def _is_on_a_word(self, info, offset):
         return next.isalnum() or next == "_"
 
 
-class _ExtractMethodParts(ast.RopeNodeVisitor):
+class _ExtractMethodParts(RopeNodeVisitor):
     def __init__(self, info):
         self.info = info
         self.info_collector = self._create_info_collector()
@@ -777,7 +780,7 @@ def get_checks(self):
         return {}
 
 
-class _FunctionInformationCollector(ast.RopeNodeVisitor):
+class _FunctionInformationCollector(RopeNodeVisitor):
     def __init__(self, start, end, is_global):
         self.start = start
         self.end = end
@@ -958,7 +961,7 @@ def _get_argnames(arguments):
     return result
 
 
-class _VariableReadsAndWritesFinder(ast.RopeNodeVisitor):
+class _VariableReadsAndWritesFinder(RopeNodeVisitor):
     def __init__(self):
         self.written = set()
         self.read = set()
@@ -998,7 +1001,7 @@ def find_reads_for_one_liners(code):
         return visitor.read
 
 
-class _BaseErrorFinder(ast.RopeNodeVisitor):
+class _BaseErrorFinder(RopeNodeVisitor):
     @classmethod
     def has_errors(cls, code):
         if code.strip() == "":
@@ -1066,7 +1069,7 @@ def _ClassDef(self, node):
         pass
 
 
-class _GlobalFinder(ast.RopeNodeVisitor):
+class _GlobalFinder(RopeNodeVisitor):
     def __init__(self):
         self.globals_ = OrderedSet()
 
@@ -1081,13 +1084,13 @@ def _get_function_kind(scope):
 def _parse_text(body):
     body = sourceutils.fix_indentation(body, 0)
     try:
-        node = ast.parse(body)
+        node = rope.base.ast.parse(body)
     except SyntaxError:
         # needed to parse expression containing := operator
         try:
-            node = ast.parse("(" + body + ")")
+            node = rope.base.ast.parse("(" + body + ")")
         except SyntaxError:
-            node = ast.parse(
+            node = rope.base.ast.parse(
                 "async def __rope_placeholder__():\n"
                 + sourceutils.fix_indentation(body, 4)
             )