You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rename rope.base.ast.parse to rope_parse, adding from rope.base.ast import rope_parse as needed.
Add comment in rope.refactor.extract._parse_text that ast.parse refers to stdlib.ast.parse.
Add comment about call_for_nodes in rope.refactor.patchedast.
If accepted, PR PR: eliminate call_for_nodes #633 will eliminate call_for_nodes entirely.
Pitch
Removes any possibility of confusion between stdlib.ast.parse and rope.base.ast.parse.
Removes unnecessary qualifications for rope_parse.
Prepares for another PR that will remove unnecessary qualifications for RopeNodeVisitor.
This change just making the code more confusing. The purpose of rope.base.ast.parse() being named identically to ast.parse() is because there is zero reason for any of rope's code to use the standard library version in rope's codebase. rope.base.ast backports changes from future standard library ast; and it may also add some code that are useful for rope. It is intended to be a drop-in replacement of the standard library ast.
You seem to have a rather unhealthy obsession with the rope.base.ast module for some reason, can I ask you to move away from ast module for now and look for something other areas to improve on. These PRs trying to make it into what it isn't are counter-productive and aren't really moving the codebase towards the direction that we needed/wanted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR designed to reduce diffs in PR #632.
rope.base.ast.parsetorope_parse, addingfrom rope.base.ast import rope_parseas needed.rope.refactor.extract._parse_textthatast.parserefers tostdlib.ast.parse.call_for_nodesinrope.refactor.patchedast.If accepted, PR PR: eliminate call_for_nodes #633 will eliminate
call_for_nodesentirely.Pitch
stdlib.ast.parseandrope.base.ast.parse.rope_parse.RopeNodeVisitor.from ast import *from rope.base.ast #632.