ci: define timeout on macOS
#6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
added
area/ci
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
2 tasks
neersighted
approved these changes
Sep 24, 2022
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6618-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aee025ea9c15036b3034f0bc48873ca6234bcae2
# Push it to GitHub
git push --set-upstream origin backport-6618-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2Then, create a pull request where the |
neersighted
added a commit
to python-poetry/cleo
that referenced
this pull request
Sep 27, 2022
Originally from python-poetry/poetry#6618, python-poetry/poetry#6586. Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com> Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
mkniewallner
added a commit
to mkniewallner/poetry-core
that referenced
this pull request
Oct 11, 2022
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com> Applying the same fix as in python-poetry/poetry#6618.
neersighted
pushed a commit
to python-poetry/poetry-core
that referenced
this pull request
Oct 11, 2022
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com> Applying the same fix as in python-poetry/poetry#6618.
DavidVujic
pushed a commit
to DavidVujic/poetry-core
that referenced
this pull request
Oct 16, 2022
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com> Applying the same fix as in python-poetry/poetry#6618.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Closes #6602.
Cache is never reused on macOS because we use
timeoutto validate cache healthiness, buttimeoutis not available on macOS. So as the command fails, we execute the condition after||that deletes the virtual env, meaning we never use the cache on macOS (this can easily be seen here for instance).This PR is an alternative implementation to #6602 following some feedback received in the PR.