-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: bump version to 1.1.0 #132
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to block 1.1 on #121 if we can get it finished this weekend.
probably depends on whether you're willing to overlook, or rectify, the missing testcase ... |
The intention is to write the test case, yes. I likely will just implement it myself in a successor as the existing PR is not quite correct and the contributor is stuck on writing tests. |
The weekend is over so let's go on. We shouldn't delay poetry 1.2.2 and thereby eventually poetry 1.3.0 because of this. By the way, #121 seems like a simple bugfix that can go in a patch release at any time and should not block this release. |
Go ahead and do it -- I haven't started on rewriting that PR, though it is still quite trivial to fix, I just need to find time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we should bump our Poetry-core dep to 1.2.x -- otherwise, LGTM.
IMO that's not necessary because it still works with poetry-core 1.1.x. Bumping poetry-core effectively means bumping poetry to 1.2.1. We'll do a bump after the next release of poetry/poetry-core anyway to fix some typing issues. |
Fair enough! |
Added
constraints.txt
files (#128).Fixed
-o
was not interpreted relative to the current working directory (#130).