-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constraints.txt support #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs a test to make sure that we raise an exception when an editable dependency is exported in constraints.txt mode
While we are here, I think it could be a good idea to do a small refactor and extract some base |
We used to have something like that -- but for now, this simpler approach with method dispatch looks preferable to me. An ABC exporter that each format extends definitely makes sense if we ever go beyond pip's two 'txt' formats (e.g. a Pipfile.lock or something). |
8f6029b
to
62e5cfa
Compare
I've pushed two commits that amend your code to rearrange the exporter more in-line with the prior code, as well as to add a test for editable exports in constraints.txt format properly throwing |
62e5cfa
to
017ceae
Compare
fe6c115
to
ae3c8fc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks for helping to see this through! (Sorry for my lack of editable mode tests. I swear I tested a setup similar to what you did and it didn't work for me but I must have been mistaken.) |
Thanks for adding this! I ran into this exact issue today and was very pleased to see this already addressed 🎉 |
Fixes #125