Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable installation with custom build backend and configuration options #7658

Merged
merged 9 commits into from
Mar 30, 2024
Merged

Fix editable installation with custom build backend and configuration options #7658

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8070fe1
pass build config before setuptools command; add build_editable to cu…
nulano Dec 23, 2023
b4e6900
document config setting "-C parallel=n" for number of CPUs to use for…
nulano Dec 31, 2023
f27b838
support multiple --config-settings
nulano Jan 2, 2024
01e5f06
document editable mode installation in winbuild/build.rst
nulano Jan 2, 2024
74af933
Link to stable setuptools documentation
nulano Jan 20, 2024
420150f
Update winbuild/build.rst
nulano Jan 20, 2024
bf9ba35
Merge branch 'main' into build-editable
radarhere Feb 15, 2024
d9076fa
Merge branch 'main' into build-editable
radarhere Mar 7, 2024
e6fa5df
Append custom parameter to the end of sys.argv
radarhere Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update winbuild/build.rst
  • Loading branch information
@nulano
nulano authored Jan 20, 2024
commit 420150f0e251c9519a5aea1c24546a44d489828c
2 changes: 1 addition & 1 deletion winbuild/build.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ You can also install Pillow in `editable mode`_::
winbuild\build\build_env.cmd
python.exe -m pip install -v -C raqm=vendor -C fribidi=vendor -e .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that for pip install, the config settings should go after the user-requested package. I know that for some options pip attached them to the package install requests that they follow. I think it might do the same for PEP 517 config settings as pip install may have many install requests in the same command. As in pip install pkg-X --config-setting=some=thing pkg-Y --config-setting=some=other-thing. Needs checking, though.

But I still recommend having package settings coupled with the package name/spec this way.

Suggested change
python.exe -m pip install -v -C raqm=vendor -C fribidi=vendor -e .
python.exe -m pip install -v -e . -C raqm=vendor -C fribidi=vendor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any recommendations about the order in the pip documentation, so I'll take your word for it. Testing locally, I find that either order works the same with a single package. I've created #7686 for your suggestion.


To build a wheel instead, run::
To build a binary wheel instead, run::

winbuild\build\build_env.cmd
python.exe -m pip wheel -v -C raqm=vendor -C fribidi=vendor .
Expand Down
Loading