-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify pip config settings after package #7686
Conversation
https://pip.pypa.io/en/stable/cli/pip_install/ would indicate the opposite to me Similarly, see https://pip.pypa.io/en/stable/cli/pip_install/ This is a minor change, I would just like to have reasons for things, and to be able to cite those reasons if someone comes along and requests that we change it back. |
@radarhere your screenshots don't appear related at all. What's opposite there? |
Also, pypa/build has entirely separate CLI. And it can't build several packages in one invocation. So in its case the args order is not really relevant. |
Here's one of the changes in this PR, moving the package from the end to before the settings. https://pip.pypa.io/en/stable/cli/pip_install/ indicates to me that the package should come after the settings, If that isn't clear, in the "Examples" on https://pip.pypa.io/en/stable/cli/pip_install/, it lists the following, where "--upgrade", also listed as one of the "Options" on that page, comes before the package. |
@webknjaz did you find my last comment any clearer? Even if not, could you offer any documentation that indicates that the change in this PR should be made? |
I think that pip's own docs need clarification. Pip's CLI parser can process options in any places. But there's a catch. In the past, some of the options were package-specific, while the rest were global. There used to be Your example with I don't think there's a clear doc on this, sadly. And the PEP 517 |
The changes in this PR are to our CI jobs, or to install instructions for Windows. In both cases, for the sake of clarity and simplicity, the dependencies are installed separately to Pillow, and as a general rule, one would hope that users execute the installation instructions more-or-less as-is. So any discussion about how pip will behave with multiple packages seems somewhat irrelevant - it might be good form to encourage users to use pip in a way that allows for other scenarios, but if the pip documentation doesn't lead the way in that, I don't think we need to consider it our responsibility to prepare users for complex scenarios involving a tool that isn't Pillow. |
Suggested by @webknjaz in #7658 (comment)