Move the package metadata from setup.py to setup.cfg#84
Move the package metadata from setup.py to setup.cfg#84ccordoba12 merged 2 commits intopython-lsp:developfrom
Conversation
ccordoba12
changed the title
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Hey @KOLANICH, thanks a lot for your contribution! Besides the comments and suggestions I left for you below, please address the problem flagged by Pylint in our CI.
|
It seems the only things missing before merging are the failures reported by Pylint here: https://github.com/python-lsp/python-lsp-server/runs/4693154656?check_suite_focus=true |
|
Some of them were not introduced by me, but fixed them too. |
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Hey @KOLANICH, I think this is almost ready! If you need help with the failing tests, let us know and we'll push to your branch to fix them.
Added pyproject.toml Replaced reading of the version from `_version` file with reading it from Version Control System and writing it into the file. Also fixed a bug with incorrect content of `__all__` in `__main__.py`
ccordoba12
changed the title
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @KOLANICH! Last suggestion, then this should be ready.
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks a lot @KOLANICH for your help (and patience) with this!
3 participants
Added pyproject.toml
Replaced reading of the version from
_versionfile with reading it from Version Control System and writing it into the file.Also fixed a bug with incorrect content of
__all__in__main__.pyRelated: python-lsp/python-lsp-jsonrpc#8 , palantir/python-language-server#669
Fixes #84.