Add license info to setup.py so it will show up in wheel installs#137
Merged
ccordoba12 merged 1 commit intopython-lsp:developfrom Feb 1, 2022
Merged
Conversation
ccordoba12
reviewed
Dec 15, 2021
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Hey @itsbenweeks, thanks a lot for your contribution! I left a small comment for you, otherwise looks good to me.
Member
|
@itsbenweeks, do you need help to finish this one? We can give you hand so we can have this change in our next version. |
itsbenweeks
force-pushed
the
license_metadata
branch
from
27075dc to
682cedd
Compare
Contributor
Author
|
Sorry about the slow response. Got this committed and up to date, now. |
Member
|
Thanks @itsbenweeks! But since we moved our metadata from Just take a look at PR #84 to see how to do that. |
itsbenweeks
force-pushed
the
license_metadata
branch
from
682cedd to
f3a55b8
Compare
Contributor
Author
|
Thanks for letting me know, @ccordoba12! It's been changed accordingly. |
ccordoba12
approved these changes
Feb 1, 2022
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks for your help with this @itsbenweeks!
ccordoba12
changed the title
setup.py so it will show up in wheel installs.setup.py so it will show up in wheel installs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just unable to see the license info from packaging. This will correct that.