Fix crash when uname -rs output is empty#304
Merged
HorlogeSkynet merged 6 commits intomasterfrom Sep 26, 2021
Merged
Conversation
This was referenced Jul 29, 2021
sethmlarson
reviewed
Jul 30, 2021
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Thanks for opening this, instead of changing _uname_info() instead can we change _parse_uname_content to tolerate any input? (And return {} if it gets anything it's not expecting.
Member
Author
Done ! Don't forget to squash my mess. |
Member
Author
|
Up @brejoc 🙇 |
Collaborator
|
Anyone who wants to backport anything to the 2.6/7 branches is more than welcome. The reason we don't officially support EOL is rather obvious, but the branches are there for anyone willing to maintain them. |
Member
Author
|
Yes I was actually on it (for the 2.7) 😉 |
HorlogeSkynet
added a commit
that referenced
this pull request
Sep 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT : I can backport this patch to the
python2.7-supportbranch if you're OK with that.