Fix ignored include_uname parameter#305
Merged
sethmlarson merged 2 commits intomasterfrom Aug 15, 2021
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #264 (leading to #304), I noticed that the
include_unameparameter is completely being ignored by the code base.This PR addresses this issue and propose a new test to prevent future regression.
Bye 👋
EDIT : A quick GitHub search shows that "no one" (at least on this forge) actually uses this flag.
EDIT 2 : I can backport this patch to the
python2.7-supportbranch if you're OK with that.Closes #309