This repository was archived by the owner on May 6, 2025. It is now read-only.
Add PythErrors.sol #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Nov 28, 2022
njk-64
approved these changes
Nov 28, 2022
|
@jayantk yeah definitely. However it is still not very well supported.. I liked it more if I could use it within |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PythErrors and use them in the contract. This will reduce the contract size significantly.
Based on my changes it reduces current size of the contract (after merging this) from 23.69 to 20.94 KB (The limit is 24 KB)
This change might be considered breaking as people might have already try/catch it and checked the actual message (although unlikely). It's breaking for off-chain consumers such as price pusher. However, since we have not deployed the v2 contract, I consider it minor. Moving forward we should mark our not-deployed changes as alpha or beta. This one is going to be deployed soon and I don't add alpha/beta.
Note: On this PR I also modified
parsePriceFeedUpdatesin the mock contract to be similar to the actual implementation.